From 545fb415b2091ae250ea3b727f10f65c27f21d7e Mon Sep 17 00:00:00 2001
From: Jacek Jendrzej <satbaby@kawaii.com>
Date: Fri, 17 Nov 2017 06:34:13 +0100
Subject: [PATCH] fix logic and possible memleak

---
 libarmbox/video.cpp | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)

diff --git a/libarmbox/video.cpp b/libarmbox/video.cpp
index 1192f08..41e283d 100644
--- a/libarmbox/video.cpp
+++ b/libarmbox/video.cpp
@@ -220,15 +220,19 @@ int decode_frame(AVCodecContext *codecContext,AVPacket &packet, FILE* fp)
 AVCodecContext* open_codec(AVMediaType mediaType, AVFormatContext* formatContext)
 {
 	int stream_index = av_find_best_stream(formatContext, mediaType, -1, -1, NULL, 0);
-	if (stream_index < 0){
-		return NULL;
+	if (stream_index >=0 ){
+		AVCodecContext * codecContext = formatContext->streams[stream_index]->codec;
+		if(codecContext){
+			AVCodec *codec = avcodec_find_decoder(codecContext->codec_id);
+			if(codec){
+				if ((avcodec_open2(codecContext, codec, NULL)) != 0){
+					return NULL;
+				}
+			}
+			return codecContext;
+		}
 	}
-	AVCodecContext * codecContext = formatContext->streams[stream_index]->codec;
-	AVCodec *codec = avcodec_find_decoder(codecContext->codec_id);
-	if (codec && (avcodec_open2(codecContext, codec, NULL)) != 0){
-		return NULL;
-	}
-	return codecContext;
+	return NULL;
 }
 
 int image_to_mpeg2(const char *image_name, const char *encode_name)
@@ -253,11 +257,11 @@ int image_to_mpeg2(const char *image_name, const char *encode_name)
 					}
 					fclose(fp);
 				}
-				avcodec_close(codecContext);
 				av_free_packet(&packet);
 			}
-			avformat_close_input(&formatContext);
+			avcodec_close(codecContext);
 		}
+		avformat_close_input(&formatContext);
 	}
 	av_free(formatContext);
 	return 0;