mirrors/neutrino
1
0
Fork 0
mirror of https://github.com/tuxbox-neutrino/neutrino.git synced 2025-08-27 15:32:59 +02:00
Code Issues Packages Projects Releases Wiki Activity

helpers/readFile: limit memory allocations

Browse Source
This commit is contained in:
Stefan Seyfried
2017-10-01 14:38:52 +02:00
committed by Jacek Jendrzej
parent 0d9139054a
commit 2f39081708
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/system/helpers.cpp
View File

@@ -1455,8 +1455,16 @@ string readFile(string file)
if (tmpData.is_open()) { if (tmpData.is_open()) {
tmpData.seekg(0, tmpData.end); tmpData.seekg(0, tmpData.end);
int length = tmpData.tellg(); int length = tmpData.tellg();
if (length > 0xffff) { /* longer than 64k? better read in chunks! */
cerr << __func__ << ": file " << file << " too big (" << length << " bytes)" << endl;
return "";
}
tmpData.seekg(0, tmpData.beg); tmpData.seekg(0, tmpData.beg);
char* buffer = new char[length+1]; char* buffer = new char[length+1];
if (! buffer) {
cerr << __func__ << ": allocating " << (length + 1) << " bytes for buffer failed" << endl;
return "";
}
tmpData.read(buffer, length); tmpData.read(buffer, length);
tmpData.close(); tmpData.close();
buffer[length] = '\0'; buffer[length] = '\0';