From 860e777104f9ab84705fe2591cc8af5f1654925f Mon Sep 17 00:00:00 2001 From: Thilo Graf Date: Sun, 19 Mar 2023 22:20:24 +0100 Subject: [PATCH] update: remove unnecessary initialization on the heap --- src/gui/update.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/gui/update.cpp b/src/gui/update.cpp index 587fbc1fb..0d8caa5b5 100644 --- a/src/gui/update.cpp +++ b/src/gui/update.cpp @@ -422,8 +422,8 @@ bool CFlashUpdate::checkVersion4Update() showGlobalStatus(20); hide(); - versionInfo = new CFlashVersionInfo(newVersion); // Memory leak: versionInfo - sprintf(msg, g_Locale->getText(LOCALE_FLASHUPDATE_MSGBOX), versionInfo->getType(true), versionInfo->getVersionString(), versionInfo->getDate(), versionInfo->getTime()); + CFlashVersionInfo versionInfo(newVersion); + sprintf(msg, g_Locale->getText(LOCALE_FLASHUPDATE_MSGBOX), versionInfo.getType(true), versionInfo.getVersionString(), versionInfo.getDate(), versionInfo.getTime()); if (gotImage) { @@ -431,7 +431,6 @@ bool CFlashUpdate::checkVersion4Update() if ((strncmp(PACKAGE_RELEASE_CYCLE, versionInfo->getReleaseCycle(), 2) != 0) && (ShowMsg(LOCALE_MESSAGEBOX_INFO, LOCALE_FLASHUPDATE_WRONGBASE, CMsgBox::mbrYes, CMsgBox::mbYes | CMsgBox::mbNo, NEUTRINO_ICON_UPDATE) != CMsgBox::mbrYes)) { - delete versionInfo; return false; } #endif @@ -439,12 +438,9 @@ bool CFlashUpdate::checkVersion4Update() if ((fileType != '0' /*Release*/) && (ShowMsg(LOCALE_MESSAGEBOX_INFO, LOCALE_FLASHUPDATE_EXPERIMENTALIMAGE, CMsgBox::mbrYes, CMsgBox::mbYes | CMsgBox::mbNo, NEUTRINO_ICON_UPDATE) != CMsgBox::mbrYes)) { - delete versionInfo; return false; } } - - delete versionInfo; } else {