COSDFader: rename member functions, adapt implementations

Stop() is not exactly attributable if fader class used as inherited and
Fade() don't tell really what done and related to return value 'bool'...
especially as the fader class members have been not documented.


Origin commit data
------------------
Branch: ni/coolstream
Commit: 69e2debb02
Author: Thilo Graf <dbt@novatux.de>
Date: 2014-05-30 (Fri, 30 May 2014)



------------------
This commit was generated by Migit

src/driver/fade.cpp

@@ -43,7 +43,7 @@ COSDFader::COSDFader(unsigned char & alpha)
 
 COSDFader::~COSDFader()
 {
-	Stop();
+	StopFade();
 }
 
 void COSDFader::StartFadeIn()
@@ -85,7 +85,7 @@ bool COSDFader::StartFadeOut()
 	return ret;
 }
 
-void COSDFader::Stop()
+void COSDFader::StopFade()
 {
 	if ( fadeIn || fadeOut ) {
 		g_RCInput->killTimer(fadeTimer);
@@ -100,7 +100,7 @@ void COSDFader::Stop()
 }
 
 /* return true, if fade out done */
-bool COSDFader::Fade()
+bool COSDFader::FadeDone()
 {
 	bool ret = false;
 

src/driver/fade.h

@@ -36,12 +36,12 @@ class COSDFader
 		CFrameBuffer            *frameBuffer;
 	public:
 		COSDFader(unsigned char &alpha);
-		~COSDFader();
+		virtual ~COSDFader();
 
 		void StartFadeIn();
 		bool StartFadeOut();
-		void Stop();
-		bool Fade();
-		uint32_t GetTimer() { return fadeTimer; };
+		void StopFade();
+		bool FadeDone();
+		uint32_t GetFadeTimer() { return fadeTimer; };
 };
 #endif