mirrors/recycled-ni-neutrino
1
0
Fork 0
mirror of https://github.com/tuxbox-fork-migrations/recycled-ni-neutrino.git synced 2025-08-29 16:31:05 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix stack buffer overflow if icon pic is broken

Browse Source 
Origin commit data
------------------
Commit: d8d07eddf7
Author: Jacek Jendrzej <overx300@gmail.com>
Date: 2019-03-09 (Sat, 09 Mar 2019)
This commit is contained in:
Jacek Jendrzej
2019-03-09 20:09:28 +01:00
committed by vanhofen
parent 67ec132fc5
commit 9112865e66
2 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/driver/pictureviewer/pictureviewer.cpp
View File

@@ -808,7 +808,7 @@ fb_pixel_t * CPictureViewer::int_getImage(const std::string & name, int *width,
if (access(name.c_str(), R_OK) == -1)
return NULL;
int x, y, load_ret, bpp = 0;
int x = 0, y = 0, load_ret = 0, bpp = 0;
CFormathandler *fh = NULL;
unsigned char * buffer = NULL;
fb_pixel_t * ret = NULL;
@@ -820,6 +820,10 @@ fb_pixel_t * CPictureViewer::int_getImage(const std::string & name, int *width,
mode_str = "getIcon";
fh = fh_getsize(name.c_str(), &x, &y, INT_MAX, INT_MAX);
if (x < 1 || y < 1){
return NULL;
}
size_t bufsize = x * y * 4;
if (!checkfreemem(bufsize))
return NULL;