add a 'safe_system' function which avoids leaking FDs

Origin commit data
------------------
Branch: ni/coolstream
Commit: 60454a643c
Author: Stefan Seyfried <seife@tuxbox-git.slipkontur.de>
Date: 2011-12-04 (Sun, 04 Dec 2011)


------------------
No further description and justification available within origin commit message!

------------------
This commit was generated by Migit
This commit is contained in:
Stefan Seyfried
2011-12-04 16:24:57 +01:00
parent 724b91e6d9
commit b8b64efebe
3 changed files with 38 additions and 0 deletions

View File

@@ -22,6 +22,7 @@ endif
noinst_LIBRARIES = libneutrino_system.a
libneutrino_system_a_SOURCES = \
safe_system.c \
localize.cpp setting_helpers.cpp debug.cpp \
ping.c flashtool.cpp httptool.cpp \
settings.cpp lastchannel.cpp \

26
src/system/safe_system.c Normal file
View File

@@ -0,0 +1,26 @@
/*
* (C) 2011 Stefan Seyfried <seife@tuxboxcvs.slipkontur.de>
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include <fcntl.h>
#include <stdlib.h>
int safe_system(const char *command)
{
int fd;
/* hm, what if we have more than 256 FDs open? */
for (fd = 3; fd < 256; fd++)
fcntl(fd, F_SETFD, FD_CLOEXEC);
return system(command);
}

11
src/system/safe_system.h Normal file
View File

@@ -0,0 +1,11 @@
#ifndef _SAFE_SYSTEM_H_
#define _SAFE_SYSTEM_H_
#ifdef __cplusplus
extern "C"
{
#endif
extern int safe_system(const char *);
#ifdef __cplusplus
}
#endif
#endif