mirrors/recycled-ni-neutrino
1
0
Fork 0
mirror of https://github.com/tuxbox-fork-migrations/recycled-ni-neutrino.git synced 2025-08-26 23:13:00 +02:00
Code Issues Packages Projects Releases Wiki Activity

update: remove unnecessary initialization on the heap

Browse Source 
Origin commit data
------------------
Branch: ni/coolstream
Commit: 81bfacf992
Author: Thilo Graf <dbt@novatux.de>
Date: 2023-03-19 (Sun, 19 Mar 2023)


------------------
No further description and justification available within origin commit message!

------------------
This commit was generated by Migit
This commit is contained in:
Thilo Graf
2023-03-19 22:20:24 +01:00
committed by vanhofen
parent cda5398c4e
commit e8d867ca8a
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/gui/update.cpp
View File

@@ -420,8 +420,8 @@ bool CFlashUpdate::checkVersion4Update()
hide();
versionInfo = new CFlashVersionInfo(newVersion); // Memory leak: versionInfo
sprintf(msg, g_Locale->getText(LOCALE_FLASHUPDATE_MSGBOX), versionInfo->getType(true), versionInfo->getVersionString(), versionInfo->getDate(), versionInfo->getTime());
CFlashVersionInfo versionInfo(newVersion);
sprintf(msg, g_Locale->getText(LOCALE_FLASHUPDATE_MSGBOX), versionInfo.getType(true), versionInfo.getVersionString(), versionInfo.getDate(), versionInfo.getTime());
if (gotImage)
{
@@ -429,7 +429,6 @@ bool CFlashUpdate::checkVersion4Update()
if ((strncmp(PACKAGE_RELEASE_CYCLE, versionInfo->getReleaseCycle(), 2) != 0) &&
(ShowMsg(LOCALE_MESSAGEBOX_INFO, LOCALE_FLASHUPDATE_WRONGBASE, CMsgBox::mbrYes, CMsgBox::mbYes | CMsgBox::mbNo, NEUTRINO_ICON_UPDATE) != CMsgBox::mbrYes))
{
delete versionInfo;
return false;
}
#endif
@@ -437,12 +436,9 @@ bool CFlashUpdate::checkVersion4Update()
if ((fileType != '0' /*Release*/) &&
(ShowMsg(LOCALE_MESSAGEBOX_INFO, LOCALE_FLASHUPDATE_EXPERIMENTALIMAGE, CMsgBox::mbrYes, CMsgBox::mbYes | CMsgBox::mbNo, NEUTRINO_ICON_UPDATE) != CMsgBox::mbrYes))
{
delete versionInfo;
return false;
}
}
delete versionInfo;
}
else
{